Commit 43446949 authored by Linus Nordberg's avatar Linus Nordberg

Have radmsg_copy_attrs() return error in all error cases.

Also when copying of the first attribute fails.
parent 26c8061a
...@@ -106,9 +106,7 @@ struct tlv *radmsg_gettype(struct radmsg *msg, uint8_t type) { ...@@ -106,9 +106,7 @@ struct tlv *radmsg_gettype(struct radmsg *msg, uint8_t type) {
* If all attributes were copied successfully, the number of * If all attributes were copied successfully, the number of
* attributes copied is returned. * attributes copied is returned.
* *
* If copying failed, a negative number is returned. The number * If copying failed, a negative number is returned. */
* returned is 0 minus the number of attributes successfully copied
* before the failure. */
int radmsg_copy_attrs(struct radmsg *dst, int radmsg_copy_attrs(struct radmsg *dst,
const struct radmsg *src, const struct radmsg *src,
uint8_t type) uint8_t type)
...@@ -119,7 +117,7 @@ int radmsg_copy_attrs(struct radmsg *dst, ...@@ -119,7 +117,7 @@ int radmsg_copy_attrs(struct radmsg *dst,
for (node = list_first(list); node; node = list_next(node)) { for (node = list_first(list); node; node = list_next(node)) {
if (radmsg_add(dst, copytlv((struct tlv *) node->data)) != 1) { if (radmsg_add(dst, copytlv((struct tlv *) node->data)) != 1) {
n = -n; n = -1;
break; break;
} }
n++; n++;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment